Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Device name length restriction?

On Tue, 9 Sep 2008, Nicolas Joly wrote:

IMHO this code should be merged into adt7467c_match(); there is no
gain with such a function here.

Yeah, I'm not sure why it was a separate function in the original code
from the 7463 driver.  I guess if we merge it here, we should merge it
there, too?


OK, I'll send you some diffs for approval. Probably in the next day or two.

And c_id/d_id should be of type uint8_t.

Yep - looks like the 7463 driver's read command is currently defined as
int - that probably should be cleaned up, but since I don't have any
7463's I'll leave that for someone else.  :)

I have one handy ... ;-)

Kewl. I'll send separate diffs for this so you can test to make sure I don't break anything.

I'll try to squeeze these in alongside hacking up a adt7475 driver for my own motherboards!

|   Paul Goyette   | PGP DSS Key fingerprint: |  E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 |   |
| Network Engineer | 0786 F758 55DE 53BA 7731 | |

Home | Main Index | Thread Index | Old Index