Re: Device name length restriction?

[Michael Lorenz <macallan%netbsd.org@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

On Sep 8, 2008, at 4:41 PM, Paul Goyette wrote:

> BTW, would it be reasonable to add a chip-verification routine to  
> the adt7467 driver?

Yes.

> Currently the driver's match routine blindly returns "1".

That's because it's main use is on macppc where it attaches as  
adt7467c at ki2c, the attachment to iic has never been well tested.  
For ki2c we don't need to specify an address since we can get it from  
OpenFirmware's device tree.
A verify function should be easy - the chip has three registers which  
return a device ID of some sort.

> The adt7463 driver has a "chip verify" routine to check the chip's
> company_id and device_id registers.  The 7467 has similar registers  
> (documented in the data sheet) and hard-coded values.  Since both  
> chips (and possibly other dbCool chips) share the same i2c bus  
> address, it seems to me to be a worthwhile thing to check.

Feel free to fix it.
Also, the chip supports more fans than the driver currently reports,  
mainly because in iBooks only one fan is wired up - you may want to  
fix that too.

> I've actually written the code to do it, so if someone actually has  
> a machine with an adt7467 I love to have them verify that my verify  
> code actually works.

I have one in my iBook G4 but no NetBSD on it since its disk died and  
the only replacement I had at hand was a 6GB Toshiba, barely enough  
for MacOS X. I'd like to hear from someone with an adt7467 in  
something that's not a Mac and maybe uses more than fan input.

have fun
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)

iQEVAwUBSMWUo8pnzkX8Yg2nAQJKewf9Ge/4MQBTijnUw0OcPHd8rhyhSnkrLB5b
O89xSMTCaNrHF5ljdVnJRdD5f9eA92sg9nRhrhv4VrnHBXcTDhhIpniLB6BZ7Qxv
SR2oCkxJkFUAN6n9ZtPqIUhMlBX5UPvfcTNm+iNTA3vnzOtL9n/KgGOO6eEXdgBU
s1dxD1XOSlO86IUNcjF5FfH6kFgktJHq+9ksQ686XTB0q1pTOS+W9rzCdryi18HA
g/BKHj84phtiV0uf8A05rjQVnFa6raaCqZq+VDxVXEJcapcceVuGN7vKVhj9WpDL
/id6fDNUDHqqa6s7mOOeEPs1szuEXUhbMR2mFlU/0+TfiNqJzIzbXA==
=nWSO
-----END PGP SIGNATURE-----