Re: xfce4-power-manager fails to build on NetBSD

[Paolo Vincenzo Olivo <vms%retrobsd.ddns.net@localhost>]

On 25/05/10 09:26AM, Greg Troxel wrote:
> "David H. Gutteridge" <david%gutteridge.ca@localhost> writes:
> 
> > On Wed, 07 May 2025 at 08:42:58 -0400, Greg Troxel wrote:
> >> It seems the issue is that in xfpm-pm-helper.c, it expects one of
> >> BACKEND_TYPE_${OPSYS} to be defined, and upstream has support for
> >> Linux,
> >> FreeBSD, OpenBSD.   There is patches/patch-src_xfpm-pm-helper.c which
> >> adds BACKEND_TYPE_NETBSD, but I don't see how configure.ac is patched
> >> to
> >> add NetBSD, or the OS type is probed.
> >> 
> >
> > The issue is in part caused by the recent update to upower, which
> > started pulling in polkit as a buildlink dependency. But really this
> > simply exposed a pre-existing issue with this package itself, which has
> > kind of been bit-rotting over time. The update made to it to 4.20
> > incorrectly dropped a build fix patch, which was meant for non-NetBSD
> > but more recently was also papering over the fact, yes, NetBSD isn't
> > even defined as a target upstream and there's no patch being carried
> > for that, either. (So, the package built but was useless in at least
> > some regards for NetBSD.)
> >
> 
> I don't actually want to run it, but it's part of the meta package.
> Should we just comment it out from there until fixed?

I decided to attempt to fix this, as I was the one to update upower.
The last couple of commits should have sorted it out (on NetBSD and
SunOS).
Please test.

Regards,
Paolo