Re: Unusable Realtek NIC after upgrading to NetBSD 9

[SAITOH Masanobu <msaitoh%execsw.org@localhost>]

On 2020/09/17 5:50, Rocky Hotas wrote:
> On set 16 12:22, Martin Husemann wrote:
> > Can you please provide full dmesg, and output and from
> >
> > 	pcictl dump -b 3 -d 0 -f 0
>
> Full dmesg from 8.1 kernel:
>
> https://termbin.com/t57g
>
> Full dmesg from current (9.99.72) kernel:
>
> https://termbin.com/uhaa

diff -u t57g uhaa
(snip)
-re0: interrupting at msi2 vec 0
-re0: Unknown revision (0x40c00000)
+re0: interrupting at msix3 vec 0

0x40c00000 is RTK_HWREV_8105E_SPIN1.

See:
	http://mail-index.netbsd.org/source-changes/2019/12/17/msg112017.html

Other OSes have much more quirks than NetBSD but NetBSD doesn't.

I think it would be worth to try the following change:
Index: rtl8169.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/rtl8169.c,v
retrieving revision 1.166
diff -u -p -r1.166 rtl8169.c
--- rtl8169.c	13 Mar 2020 04:08:07 -0000	1.166
+++ rtl8169.c	17 Sep 2020 10:00:37 -0000
@@ -647,7 +647,6 @@ re_attach(struct rtk_softc *sc)
 			break;
 		case RTK_HWREV_8401E:
 		case RTK_HWREV_8105E:
-		case RTK_HWREV_8105E_SPIN1:
 		case RTK_HWREV_8106E:
 			sc->sc_quirk |= RTKQ_PHYWAKE_PM |
 			    RTKQ_DESCV2 | RTKQ_NOEECMD | RTKQ_MACSTAT |
@@ -658,6 +657,7 @@ re_attach(struct rtk_softc *sc)
 			    RTKQ_DESCV2 | RTKQ_NOEECMD | RTKQ_MACSTAT |
 			    RTKQ_CMDSTOP; /* CMDSTOP_WAIT_TXQ */
 			break;
+		case RTK_HWREV_8105E_SPIN1: /* XXX */
 		default:
 			aprint_normal_dev(sc->sc_dev,
 			    "Unknown revision (0x%08x)\n", hwrev);



> Output of `pcictl pci0 dump -b 3 -d 0 -f 0':
>
> https://termbin.com/udgn
>
> > Could be anyhting, like newer ACPI version or whatever. Have you checked
> > for firmware updates for your machine?
>
> This is a very old laptop. I just found a 2014 firmware update (which
> I'm almost sure had not been installed), but it's only available for
> Windows, so, having only NetBSD, I couldn't install it.
> About ACPI, I really don't know, but I hope that the two dmesg can
> provide some more information.
>
> Rocky


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)