Re: pkgsrc patches for Darwin 17.3.0

[Jonathan Perkin <jperkin%joyent.com@localhost>]

tl;dr please hold off on all of these at least until after the branch

* On 2018-03-29 at 15:18 BST, Brook Milligan wrote:

> Both of these packages have the same problem; the -nonet option to
> xsltproc prevents downloading certain files.  For example, the
> following error occurs (along with analogous ones for other files):

This one has already been addressed, and we should figure out the
correct fix instead of this workaround.

> ==========================
> packages requiring libintl
> ==========================
> 
> At least on this system, several packages require libintl but lack a dependency on level/gettext-lib.

I think this is due to a missing gettext-lib in one of the dependency
buildlink3's, possibly fontconfig.  That should be fixed instead (it
may already have been IIRC).

> ==========================================
> packages incorrectly using a native libXft
> ==========================================
> 
> As described in http://mail-index.netbsd.org/tech-pkg/2018/03/28/msg019575.html, some packages incorrectly select a native libXft with pig-config and consequently fail.  One solution seems to be to add the following to etc/mk.conf:
> 
> PREFER_PKGSRC+=  Xft2 freetype2 fontconfig
> 
> However, I note that mk/defaults/mk.conf has the following snippet:
> 
> # The default PREFER_PKGSRC should be empty, but due to historical reasons we have the list below.
> # Please add your platform here once you have confirmed it is correct
> .if ${OPSYS} == "OpenBSD" || ${OPSYS} == "Bitrig"
> ...

Yes, this section is horrendously broken, but now is not the time to
fix it.  None of it should be there, so please don't add more
workarounds.  The correct fix is to ensure the builtin.mk for each
package is correct, but that should be done post-branch.

Cheers,

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com