Re: pkg/56586: Support keeping worklog of succeeded packages in pbulk

[manphiz <manphiz%gmail.com@localhost>]

On Thu, Dec 30, 2021 at 6:57 PM Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
>
> On Thu, Dec 30, 2021 at 05:45:07PM -0800, manphiz wrote:
> > On Thu, Dec 30, 2021 at 10:59 AM Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> > >
> > > On Thu, Dec 30, 2021 at 11:55:08AM +0100, Benny Siegert wrote:
> > > > Joerg, you do not have to use this option if you think it is not
> > > > useful. But the submitter does have a use case for it, and a simple
> > > > patch of less than 10 lines does not warrant this amount of discussion
> > > > IMHO. I vote for adding the patch.
> > >
> > > Options have a cost. As such they have to be justified against the
> > > alternatives.
> > >
> > > Joerg
> >
> > Hi Joerg,
> >
> > Understood.  Still I would suggest adding this feature as it's easier
> > to use compared to your suggested alternatives, which requires:
> >
> > * Knowing how to use DEPENDS_TARGET and BINPKG_SITES which are
> > introduced at different places in the pkgsrc guide.
> >
> > * Making sure to use the same PKG_OPTIONS for the packages of interest
> > in both pbulk and pkgsrc, which if not kept the same may not trigger
> > the same issue.
> >
> > * Having to build it again, which means more time spent.  For me it's
> > 1-2 hours for building gnupg2 itself.
> >
> > If it can be done in pbulk itself by changing a single flag it can
> > make life easier for pkgsrc newbies like myself.
>
> Like I said, I can't remember a case were I didn't want to do such a
> rebuild and learning how to reproduce the pbulk environment
> interactively seems much more useful than a hack that you could obtain
> by just commenting out the line in first place.
>
> In other words: I can't think of a good reason for having this flag ever
> set permanently in the config file and all other cases are better served
> by learning how to do the above.
>
> Joerg

Joerg, what you insisted got me curious about the "keep_wrkdir" flag
whose effect can also be achieved by what you suggested but is somehow
supported in pbulk.