tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Making DESTDIR support mandatory

On Sun, 12 May 2013 19:05:08 +0900, Thomas Klausner <> 

On Sun, May 12, 2013 at 06:49:58PM +0900, OBATA Akio wrote:
Attached patch should resolve a regression of USE_DESTDIR=yes,
and binary package will not be created unless `package' target
is invoked.

I assume bulk builds call that target?

To create binary package, "package"
To install package from source, "install"
For both of them, "package-install"

I wonder if you have tested with USE_DESTDIR=no, see:
+.if ${_USE_DESTDIR} == "no"
+STAGE_PKGFILE?=                ${PKGFILE
There's a '}' missing at the end of line here.

Thanks (my keyboard's `}' is sometimes broken...)
Attached patch fix it, plus USE_DESTDIR=no install & replace.

The other thing I wonder is if we should still add code that checks
for USE_DESTDIR=no when we have less than 20 packages left in this

USE_DESTDIR=no is faster than "yes" unless CKECK_FILES=yes :)

OBATA Akio /

Attachment: pkg-create.patch
Description: Binary data

Home | Main Index | Thread Index | Old Index