tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: missing patch comments should not be classified as an error

On 9/16/2012 04:49, David Holland wrote:
On Sat, Sep 15, 2012 at 09:18:48PM +0200, John Marino wrote:
  >  >   >   Can we get this put back to a warning?
  >  >
  >  >Given that the change was made intentionally in response to the last
  >  >round of flamage on this issue, I doubt you'll convince anyone.
  >  >
  >  >I think it's fine the way it is...
  >  Alright, then I'll just locally remove this error from pkglint and
  >  the "new pkglint" available warning and not update it anymore.
  >  Having it as a warning was obnoxious enough, but one could live
  >  with that.

That is... not really a constructive attitude. If nothing else, please
at least carry a local patch instead of not updating -- pkglint has
been getting improved lately (for a change) and with any luck this
will continue.

This is a bad change. You said nobody would agree - basically saying it wasn't worth discussing further which I find "unconstructive".

(Also, what's the difference? As far as I can tell, when you run
pkglint it just spews notices at you, and while some of them are
tagged "error", any further consequences are up to the operator...)

If you actually believed that, you wouldn't have supported the classification change of warning to error. Both spew notices leaving further consequences to operator, so a classification change would therefore have no benefit.

Home | Main Index | Thread Index | Old Index