Re: Extra files in DESTDIR with MKRUMP=no

["Ian D. Leroux" <idleroux%fastmail.fm@localhost>]

On Thu, 29 Jan 2015 10:39:42 +0000 (GMT) Robert Swindells
<rjs%fdy2.co.uk@localhost> wrote:
> idleroux%fastmail.fm@localhost wrote:
> I also build with MKRUMP=no but have the following extra patch in my
> local tree:
> 
> Robert Swindells
> 
> Index: tests/mi
> ===================================================================
> RCS file: /cvsroot/src/distrib/sets/lists/tests/mi,v
> retrieving revision 1.610
> diff -u -r1.610 mi
> --- tests/mi    14 Jan 2015 22:25:05 -0000      1.610
> +++ tests/mi    29 Jan 2015 10:41:34 -0000
> @@ -3146,7 +3146,7 @@
>  ./usr/tests/net/in_cksum/t_in_cksum            tests-net-tests         atf
>  ./usr/tests/net/in_cksum/in_cksum              tests-net-tests         atf
>  ./usr/tests/net/mcast                          tests-net-tests
> -./usr/tests/net/mcast/Atffile                  tests-net-tests         atf,rump
> +./usr/tests/net/mcast/Atffile                  tests-net-tests         atf
>  ./usr/tests/net/mcast/Kyuafile                 tests-net-tests         atf,rump,kyua
>  ./usr/tests/net/mcast/t_mcast                  tests-net-tests         atf
>  ./usr/tests/net/mpls                           tests-net-tests

I've now convinced myself that this is the correct (and not just the
immediately convenient) fix.  The t_mcast test has no dependence on
rump that I can see,  src/tests/net/Makefile clearly builds it even
when MKRUMP=no (thus generating the corresponding Atffile), so the
presence of the Atffile is not dependent on rump either.  If you (Mr
Swindells) are not intending to do so yourself, I'll file a PR
(crediting you for the patch of course) so that this doesn't get
forgotten about in the list archives.

--
IDL