Re: -current dmesg changes: aprintification adding spaces; findroot error

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alan Barrett wrote:
| On Mon, 07 Apr 2008, Christoph Egger wrote:
|> |> After updating my current from March 29 to April 6, I get the
|> |> following changes in dmesg output:
|> |> -attimer1: io 0x40-0x43
|> |> +attimer1:  io 0x40-0x43
|> |
|> | Yes. This is from the last change in acpi_resource_print() :
|> |
|> | -       aprint_normal("%s:", dev->dv_xname);
|> | +       aprint_normal_dev(dev, "");
|>
|> Is this change ok, or should I have used
|>
|> aprint_normal("%s:", device_xname(dev)); ?
|
| I'd say that the two spaces after the ":" are not OK.  You should be
| able to fix it by removing the leading space at the beginning of the
| next message.  However, I think that calling aprint_normal_dev with an
| empty message is unusual, the usual way would be to wait until you have
| more information, and then do
|
|     aprint_normal_dev("io %#x-%#x", first_port, last_port);

Basically I agree with you. In acpi_resource_print(), this output
is splitted to print something useful in a loop.

Further, the code path allows to print information about
io, mem, irq, drq  in the given order in one line.
So just removing *all* leading spaces in the following aprint_normal()
will miss them later on.

Christoph
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQEcBAEBAgAGBQJH+fDuAAoJEH5bnJXp/MoMfCUIALEL+YMHoputdW4NyNzvps2B
UeOt3Jkbt1q4uBokACCG+aSPqgM725miQvvW9EPXmTCiRhUBNBphU7DZlGuexvKr
ogyX29vYwbdf+x5kprW6+RfANZbeIgFdCrr4RMgnX2hPNePUcYH2Q9whtAnRnloh
0u2bGuLz9ZPAj221LL6i9R/dUW1Wy0GpRXSbHuRQFRPnKOE+D9i/4sA1vSWhDgvo
Q0CjT8Zaoevt26YSQ878TQ9a377C5bYsSXOpV5wfe1HHf5k6SggqfQOnSCSGYLH3
RrMPo/N5Z7MfswZH+8ePNB0W1eAtwLxyb1MGzeB1xjamcGk8+onOFdQX6Tco9GA=
=PChW
-----END PGP SIGNATURE-----