Re: -current dmesg changes: aprintification adding spaces; findroot error

[Christoph Egger <Christoph_Egger%gmx.de@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Nicolas Joly wrote:
| On Mon, Apr 07, 2008 at 01:28:42AM +0200, Thomas Klausner wrote:
|> Hi!
|>
|> After updating my current from March 29 to April 6, I get the
|> following changes in dmesg output:
|> -attimer1: io 0x40-0x43
|> +attimer1:  io 0x40-0x43
|> -hpet0: mem 0xfefff000-0xfefff3ff irq 0,8
|> +hpet0:  mem 0xfefff000-0xfefff3ff irq 0,8
|> -pcppi1: io 0x61
|> +pcppi1:  io 0x61
|> -fdc0: io 0x3f0-0x3f5,0x3f7 irq 6 drq 2
|> +fdc0:  io 0x3f0-0x3f5,0x3f7 irq 6 drq 2
|> -com0: io 0x3f8-0x3ff irq 4
|> +com0:  io 0x3f8-0x3ff irq 4
|> -lpt0: io 0x378-0x37f irq 7
|> +lpt0:  io 0x378-0x37f irq 7
|>
|> Looks like something went wrong in an aprintification...
|
| Yes. This is from the last change in acpi_resource_print() :
|
| -       aprint_normal("%s:", dev->dv_xname);
| +       aprint_normal_dev(dev, "");
|
| Where it used to be "%s:", aprint_normal_dev() use "%s: " which
| explain the extra space you see.
|

Is this change ok, or should I have used

aprint_normal("%s:", device_xname(dev)); ?

Christoph
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Darwin)

iQEcBAEBAgAGBQJH+enKAAoJEH5bnJXp/MoMoF0H/j553Ojb8FJPxGMEtWfsif8l
BSkDyv8ELIBpmvrgulncjtoRR/DsNn+V1sSkZkFsqMzl2IN5u1UJq4aU5mk6nJNm
06KLZYDzzu/ghmYjwWekbkd6/L7lfJn1IjIGukDOdy/0I4w2k8hwBQ84j6OS7bhW
8dz3LFROTnyAkrILI0/dDpLh+sRVq6RO+O+JIW33kEguw80jKo8f5WCMTCJ6UIcC
TyTUOtv8zt9ShS0n/LxyjRqGDqiWKaukIBRY2Uz0Lsi2FezPv9ty6lv8Mwo2KgVa
Tgod+reOTYtJbxQH5GKbDTo9JMW/Wb+cxCaxIPy0y1d4HODk7k0OWwPjEXd+i9E=
=gH17
-----END PGP SIGNATURE-----