* On 2024-12-17 at 16:39 GMT, Brook Milligan wrote:
Not ok. This is in common code and will just end up breaking OS that support -R but not -rpath. We have COMPILER_RPATH_FLAG for this to be done properly, but I would prefer this just wait until after the freeze as there is far too much potential for breakage.So why don’t we replace the hardcoded -Wl,-R with ${COMPILER_RPATH_FLAG}?
Yeh we should, but after the branch please. If as you say this only affects builds outside of pkgsrc then it's low priority, but still has high risk in case it's used somewhere unexpected, so can wait a week.
I think under different circumstances I'd be more ok with it, but it's been a very bumpy branch thus far and we haven't even had bulk builds for the past few days, so I want to be more careful than normal.
Thanks, -- Jonathan Perkin pkgsrc.smartos.org Open Source Complete Cloud www.tritondatacenter.com