tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: math/R Makeconf fix



* On 2024-12-16 at 18:53 GMT, Brook Milligan wrote:

I would like to commit the following patch to fix a bug in Makeconf.in for the math/R package.

Makeconf (made from Makeconf.in) is a Makefile fragment that R uses to build packages or other software from within R.  Currently, it passes rpath directories to the linker using -Wl,-R.  This fails on Darwin and should be replaced by -Wl,-rpath.  While at it, the patch also uses the same argument to -rpath as used to -L.

This should not affect building R itself or R packages within pkgsrc.

Please confirm that this is OK during the freeze.

Not ok. This is in common code and will just end up breaking OS that support -R but not -rpath.

We have COMPILER_RPATH_FLAG for this to be done properly, but I would prefer this just wait until after the freeze as there is far too much potential for breakage.

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index