Re: gettext vs vlc

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Fri, Jun 04, 2021 at 08:54:50PM -0700, Michael Forney wrote:
> So, perhaps a global solution (rather than patching individual package
> configure scripts) would be something like this:
> 
> diff --git a/devel/gettext-lib/builtin.mk b/devel/gettext-lib/builtin.mk
> index 9b56dede4b5..7619761c556 100644
> --- a/devel/gettext-lib/builtin.mk
> +++ b/devel/gettext-lib/builtin.mk
> @@ -126,6 +126,7 @@ CONFIGURE_ENV+=		gt_cv_func_gnugettext1_libintl="yes"
>  .        if empty(H_NGETTEXT_GETTEXT:M__nonexistent__) && \
>  	    empty(H_NGETTEXT_GETTEXT:M${LOCALBASE}/*)
>  CONFIGURE_ENV+=		gt_cv_func_gnugettext2_libintl="yes"
> +CONFIGURE_ENV+=		gt_cv_func_gnugettext3_libintl="yes"
>  .        endif
>  .      else
>  CONFIGURE_ENV+=		gt_cv_func_gnugettext_libc="yes"
> @@ -133,6 +134,7 @@ CONFIGURE_ENV+=		gt_cv_func_gnugettext1_libc="yes"
>  .        if empty(H_NGETTEXT_GETTEXT:M__nonexistent__) && \
>  	    empty(H_NGETTEXT_GETTEXT:M${LOCALBASE}/*)
>  CONFIGURE_ENV+=		gt_cv_func_gnugettext2_libc="yes"
> +CONFIGURE_ENV+=		gt_cv_func_gnugettext3_libc="yes"
>  .        endif
>  .      endif
>  .    endif

I tried this (commenting out the sed stuff in vlc's Makefile), but
then I get an error that looks unrelated:

*** Warning: This system cannot link to static lib archive ../compat/libcompat.la.
*** I have the capability to make that library automatically link in when
*** you link to this library.  But I can only do this if you have a
*** shared version of the library, which you do not appear to have.
ld: modules/.libs/bank.o: in function `module_EndBank':
/scratch/multimedia/vlc/work/vlc-3.0.14/src/modules/bank.c:636: undefined reference to `tdestroy'
ld: /scratch/multimedia/vlc/work/vlc-3.0.14/src/modules/bank.c:636: undefined reference to `tdestroy'
ld: modules/.libs/entry.o: in function `vlc_plugin_free_symbols':
/scratch/multimedia/vlc/work/vlc-3.0.14/src/modules/entry.c:572: undefined reference to `tdestroy'
ld: modules/.libs/entry.o: in function `vlc_plugin_get_symbols':
/scratch/multimedia/vlc/work/vlc-3.0.14/src/modules/entry.c:563: undefined reference to `tdestroy'
ld: misc/.libs/actions.o: in function `libvlc_InternalActionsClean':
/scratch/multimedia/vlc/work/vlc-3.0.14/src/misc/actions.c:567: undefined reference to `tdestroy'
ld: misc/.libs/actions.o:/scratch/multimedia/vlc/work/vlc-3.0.14/src/misc/actions.c:568: more undefined references to `tdestroy' follow

but if I revert the changes and just build vlc as-is, I don't get it.
I haven't tried debugging this yet.
 Thomas