Shall security/p11-kit depend on gettext-lib?

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Hi again,

I got trouble on a Linux system with gettext in glibc and a libintl
from gettext on top. /usr/lib/libintl.la ends up in p11-kit.la from
pkgsrc and that breaks gnutls build, where /usr/lib/libintl.la is
translated to a buildlink location, but there is not actually a link
placed there.

I guess there's a buildlink issue to fix here. A workaround for me is
to resort to pkgsrc's gettext-lib. But for that to work, I need to tell
p11-kit that it actually uses gettext-lib. Otherwise it'll always pick
up /usr/lib/libintl.la.

Regardless of an eventual buildlink fix, this patch seems to be needed
… do you agree?

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/security/p11-kit/Makefile,v
retrieving revision 1.20
diff -u -r1.20 Makefile
--- Makefile    10 Jun 2021 10:20:50 -0000      1.20
+++ Makefile    3 Jul 2021 10:30:50 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.20 2021/06/10 10:20:50 wiz Exp $
 
 DISTNAME=      p11-kit-0.24.0
+PKGREVISION=   1
 CATEGORIES=    security
 #MASTER_SITES= http://p11-glue.freedesktop.org/releases/
 MASTER_SITES+= ${MASTER_SITE_GITHUB:=p11-glue/}
@@ -43,5 +44,6 @@
                        ${PKG_SYSCONFDIR}/pkcs11.conf
 
 .include "../../devel/libffi/buildlink3.mk"
+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../security/libtasn1/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"
Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/security/p11-kit/buildlink3.mk,v
retrieving revision 1.3
diff -u -r1.3 buildlink3.mk
--- buildlink3.mk       8 Mar 2020 16:42:30 -0000       1.3
+++ buildlink3.mk       3 Jul 2021 10:30:50 -0000
@@ -10,6 +10,7 @@
 BUILDLINK_ABI_DEPENDS.p11-kit?=        p11-kit>=0.23.15nb1
 BUILDLINK_PKGSRCDIR.p11-kit?=  ../../security/p11-kit
 .include "../../devel/libffi/buildlink3.mk"
+.include "../../devel/gettext-lib/buildlink3.mk"
 .include "../../security/libtasn1/buildlink3.mk"
 .endif # P11_KIT_BUILDLINK3_MK
	

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg