Re: update databases/sqlitebrowser

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Jan 30, 2019, at 10:22 PM, Greg Troxel <gdt%lexort.com@localhost> wrote:
> 
> I'mt sure think that's the right fix.  It feels like an upstream bug to
> to omit these on APPLE, even if people usuaally don't use a
> desktop/window system.
> 
> So I'd patch out the "AND NOT APPLE" in the CmakeLists.txt and file a
> bug with upstream.  If one is doing a posixy build on a mac, it should
> do the normal thing.
> 
> But, changing PLIST to be conditional seems ok too, if there is
> consensus that those files really should not be installed on a mac, even
> under pkgsrc, and even if the program is run over remote X back to
> someplace else.

OK, that makes sense.

I have been corresponding with upstream and they have agreed to remove the "AND NOT APPLE" part of the conditional as you have suggested.  See https://github.com/sqlitebrowser/sqlitebrowser/commit/21d8800ce613775c995212f61d7e95c2189f6da6.

I will go ahead and commit the equivalent patch (and the unrelated ones suggested on this thread).  Should I bump the revision to nb11, as well?  My commit will change the dependencies (two buildlink3.mk files will be added).  At some point, I'll also update this to 3.10.1 or whatever is the current release at the time.  However, right now I cannot get qt5 compiled on my Mac, which is a prerequisite.  Suggestions?

If anyone can do a quick check on the new upstream code, that would be really helpful just to verify that this has not broken anything. (I can only test 3.8.0 for the moment.)

Thanks a lot.

Cheers,
Brook