Re: update databases/sqlitebrowser

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Jan 29, 2019, at 7:33 AM, Greg Troxel <gdt%lexort.com@localhost> wrote:
> 
> Brook Milligan <brook%nmsu.edu@localhost> writes:
> 
>> I am trying to install the databases/sqlite package.  As it stands, it
> 
> I assume you mean databases/sqlitebrowser

Oops.  That is correct.

>> appears to install only the binary, even though various additional
>> files are listed in PLIST; these are all resource files (e.g.,
>> share/appdata, share/applications, share/icons).  The PLIST was
>> changed during the upgrade to 3.8.0, but I see no changes in Makefile
>> at that time to install these additional files.
>> 
>> Are resource files like that supposed to be installed automatically by
>> pkgsrc or must there be explicit post-install actions (or are there
>> magic variables to set)?
>> 
>> In any case, I had to add the following to my Makefile to get them
>> installed.  Is this the correct solution?  Should it be committed or
>> am I missing something?
> 
> This works fine for me.  I built the package on
> 
>  netbsd-8 / amd64 / pkgsrc-2018Q4 (same as head)
> 
> and here is the install output, and the files were installed.
> 
> ==> Installing for sqlitebrowser-3.8.0nb10
> => Generating pre-install file lists
> [ 13%] Built target antlr
> [ 17%] Built target qhexedit
> [ 19%] Built target qcustomplot
> [ 54%] Built target qscintilla2
> [100%] Built target sqlitebrowser
> Install the project...
> -- Install configuration: "Release"
> -- Installing: /u0/pkgsrc-current/pkgsrc/databases/sqlitebrowser/work/.destdir/usr/pkg/bin/sqlitebrowser
> -- Installing: /u0/pkgsrc-current/pkgsrc/databases/sqlitebrowser/work/.destdir/usr/pkg/share/icons/hicolor/256x256/apps/sqlitebrowser.png
> -- Installing: /u0/pkgsrc-current/pkgsrc/databases/sqlitebrowser/work/.destdir/usr/pkg/share/applications/sqlitebrowser.desktop
> -- Installing: /u0/pkgsrc-current/pkgsrc/databases/sqlitebrowser/work/.destdir/usr/pkg/share/appdata/sqlitebrowser.desktop.appdata.xml

So where do the last three lines come from?  They are not in my output, which is on a Mac.

OK, I see.  The CMakeLists.txt file has the following stanza:

if(UNIX AND NOT APPLE)
	install(FILES src/icons/${PROJECT_NAME}.png
		DESTINATION share/icons/hicolor/256x256/apps/)
	
	install(FILES distri/${PROJECT_NAME}.desktop
		DESTINATION share/applications/)

	install(FILES distri/${PROJECT_NAME}.desktop.appdata.xml
		DESTINATION share/appdata/)
endif(UNIX AND NOT APPLE)

I believe this means the the correct fix is to make part of the PLIST match the "unix and not apple" condition.  Right?

What is the best way to accomplish that?  A variable substitution in PLIST?  A split PLIST file?  Something else?

Thanks for looking at this.

Cheers,
Brook