update databases/sqlitebrowser

[Brook Milligan <brook%nmsu.edu@localhost>]

I am trying to install the databases/sqlite package.  As it stands, it appears to install only the binary, even though various additional files are listed in PLIST; these are all resource files (e.g., share/appdata, share/applications, share/icons).  The PLIST was changed during the upgrade to 3.8.0, but I see no changes in Makefile at that time to install these additional files.

Are resource files like that supposed to be installed automatically by pkgsrc or must there be explicit post-install actions (or are there magic variables to set)?

In any case, I had to add the following to my Makefile to get them installed.  Is this the correct solution?  Should it be committed or am I missing something?

A related issue is that the images/sqlitebrowser.png file distributed with the source is a screenshot of the GUI.  Thus, it seems inappropriate to install that in share/icons as suggested by the PLIST.  In contrast, the images/sqlitebrowser.svg file seems more appropriate as an icon.  Presumably, that needs to be converted to a PNG file before installation, right?  Is my solution below, i.e., commit the converted file in ${FILESDIR} the correct solution?

Thanks for your help.

Cheers,
Brook

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/databases/sqlitebrowser/Makefile,v
retrieving revision 1.24
diff -u -r1.24 Makefile
--- Makefile	30 Nov 2017 16:45:19 -0000	1.24
+++ Makefile	28 Jan 2019 08:29:09 -0000
@@ -15,6 +15,22 @@
 USE_LANGUAGES=	c c++
 USE_CMAKE=	yes
 
+INSTALLATION_DIRS+=	share/appdata
+INSTALLATION_DIRS+=	share/applications
+INSTALLATION_DIRS+=	share/icons/hicolor/256x256/apps
+
+post-extract:
+	# XXX - this image is a gimp-converted version of the
+	# images/*.svg, which presumably should be installed instead
+	# of the distributed file; the latter is an image of the GUI
+	# not an icon
+	${CP} ${FILESDIR}/sqlitebrowser.png ${WRKSRC}/images
+
+post-install:
+	${INSTALL_DATA} ${WRKSRC}/distri/sqlitebrowser.desktop ${DESTDIR}${PREFIX}/share/applications
+	${INSTALL_DATA} ${WRKSRC}/distri/sqlitebrowser.desktop.appdata.xml ${DESTDIR}${PREFIX}/share/appdata
+	${INSTALL_DATA} ${WRKSRC}/images/sqlitebrowser.png ${DESTDIR}${PREFIX}/share/icons/hicolor/256x256/apps
+
 .include "../../databases/sqlite3/buildlink3.mk"
 .include "../../x11/qt4-libs/buildlink3.mk"
 .include "../../x11/qt4-tools/buildlink3.mk"