tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: (patch) Improved documentation and examples of dynamic modules



Joerg Sonnenberger wrote:
> On Wed, May 13, 2015 at 01:52:05PM +0200, Kamil Rytarowski wrote:
> > A FreeBSD developer studying our examples told me that we traditionally use
> > u_int in place of unsigned [int] - calling the usage of 'unsigned' a linuxism.
> > I have no opinions on it. How is it?
> 
> Personally, I consider the use of u_int a historic mistake, but it is
> wildly used. Why the use of plain standard C is a Linuxism is beyond me.
> 

I sympathize with being free to use ISO C.

> > I think that src/sys/modules/examples/ping/cmd_ping.c has malformed RCSID,
> > there is missing ':' after NetBSD.
> 
> More like there should be no space. Fixed.
> 
Thanks!


The last thing, the original patch contained the following lines:
.Sh EXAMPLES
A list of example modules is located in
.Pa sys/modules/examples .

Please embed them (before the SEE ALSO section) in module.9,
driver.9 and intro.9lua this way:

.Sh EXAMPLES
A list of example modules is located in
.Pa sys/modules/examples .


.Sh EXAMPLES
A list of example drivers is located in
.Pa sys/modules/examples .


.Sh EXAMPLES
A list of example Lua modules is located in
.Pa sys/modules/examples .


There will be more examples, but not for the netbsd-7 branch (at least from me).


Home | Main Index | Thread Index | Old Index