tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Reworked: Support for multi-position electro-mechanical keylocks

On Fri, Aug 14, 2009 at 02:56:37PM +0200, Marc Balmer wrote:
> >2.) The code at the end of keylock_state() looks very condensed.
> >   Can you perhaps change the "else if" to "if" and a few
> >   comments?
> here we are at a spot of the code that definitely needs refinement and  
> more thinking.  for now, I suggest the following comment to explain  
> the situation better:
>       /*
>          * XXX How should the intermediate positions be handled?
>          * At the moment only the ultimate positions are properly  
> handled,
>          * we need to think about what we do with the intermediate  
> positions.
>          * For now we return KEYLOCK_SEMIOPEN for them.
>          */
> would that suit the needs?

Yes, thanks a lot. No further objections from me, good work.

        Kind regards

Matthias Scheler                        

Home | Main Index | Thread Index | Old Index