Re: Reworked: Support for multi-position electro-mechanical keylocks

[Mindaugas Rasiukevicius <rmind%netbsd.org@localhost>]

Marc Balmer <marc%msys.ch@localhost> wrote:
> Please find an updated diff at
> http://www.netbsd.org/~mbalmer/diffs/keylock_07.diff that includes the
> gpiolock(4) man page in the dirstribution set lists file.

> Index: sys/sys/keylock.h

I do not think this should go into sys/sys, please use sys/dev instead.

> +#if defined(_LKM)
> +SYSCTL_SETUP_PROTO(sysctl_security_keylock_setup);
> +#endif /* _LKM */

This is not modular (also, LKMs are being replaced). Rather make it fully
modular, or I would say just avoid this #ifdef.

-- 
Mindaugas