tech-kern archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Reworked: Support for multi-position electro-mechanical keylocks

On Fri, Aug 14, 2009 at 10:45:53AM +0200, Marc Balmer wrote:
> Please find an updated diff at 
> that includes the 
>  gpiolock(4) man page in the dirstribution set  lists file.

The diff looks mostly good. A few comments:
1.) "sys/keylock.h" should have guards against multiple inclusion.
2.) The code at the end of keylock_state() looks very condensed.
    Can you perhaps change the "else if" to "if" and a few

        Kind regards

Matthias Scheler                        

Home | Main Index | Thread Index | Old Index