Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src

On Sat, Aug 24, 2019 at 01:20:52PM +0000, Mindaugas Rasiukevicius wrote:
> Module Name:	src
> Committed By:	rmind
> Date:		Sat Aug 24 13:20:52 UTC 2019
> Modified Files:
> 	src/lib/libnpf: Makefile
> 	src/lib/npf:
> 	src/libexec/identd: Makefile
> 	src/usr.sbin/npf/npfctl: Makefile
> 	src/usr.sbin/npf/npfd: Makefile
> Log Message:
> libnpf fix: link the library itself to libnv; libnpf users should not be
> expected to assume this dependency.

So, this doesn't work for two reasons:

fully static builds:
- LDADD is just outright ignored, so libnpf.a contains undefined

non-MKPIE (aarch64, hppa) / toolchain doesn't always do PIC:
- libnv.a has non-PIC bits, so creating a shared library from it isn't

Home | Main Index | Thread Index | Old Index