Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: CVS commit: src/usr.bin/audiocfg

"Tetsuya Isaki" writes:
> Module Name:	src
> Committed By:	isaki
> Date:		Sat Aug 24 05:45:25 UTC 2019
> Modified Files:
> 	src/usr.bin/audiocfg: audiodev.c audiodev.h main.c
> Log Message:
> Use device unit number for index.
> The index number was too confusing such as
>  0: [ ] audio1 @ wss0
>  1: [*] audio0 @ yds0
> in my PC for example.  Here is new format:
>  [*] audio0 @ yds0
>  [ ] audio1 @ wss0
> In this style, devices are always listed in order of unit number
> and 0 always means audio0, 1 always means audio1.

this change gives me pause.

it seems to be a kind-of "cf_unit" abuse to me.  eg, if
i configure or usb-plug a lot, such that i only end up
with just "audio10" and "audio23" attached, the index
doesn't match the cf_unit.

perhaps you can sort the audio devices based upon cf_unit,
such that your original output would have the lines swapped
except for the prefix number, and then your sanity will be
saved for the normal use-case.

at the very least, please restore the previous output
format as i've used it in at least one script and perhaps
others hvae as well.  please consider that, as a general
rule, tool output is likely to be scraped and changing it
may break things, so formatting changes should be avoided
if possible.



Home | Main Index | Thread Index | Old Index