Source-Changes-D archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: src/usr.bin/audiocfg

At Sat, 24 Aug 2019 16:28:39 +1000,
matthew green wrote:
> > Log Message:
> > Use device unit number for index.
> > The index number was too confusing such as
> >  0: [ ] audio1 @ wss0
> >  1: [*] audio0 @ yds0
> > in my PC for example.  Here is new format:
> >  [*] audio0 @ yds0
> >  [ ] audio1 @ wss0
> > In this style, devices are always listed in order of unit number
> > and 0 always means audio0, 1 always means audio1.
> this change gives me pause.
> it seems to be a kind-of "cf_unit" abuse to me.  eg, if
> i configure or usb-plug a lot, such that i only end up
> with just "audio10" and "audio23" attached, the index
> doesn't match the cf_unit.

The index may not have been good name in my change.
I intended to type "audiocfg test 23" for audio23 regardless of
current total number of available devices.
I wanted to use device name like "audiocfg test audio23" at final.

> perhaps you can sort the audio devices based upon cf_unit,
> such that your original output would have the lines swapped
> except for the prefix number, and then your sanity will be
> saved for the normal use-case.
> at the very least, please restore the previous output
> format as i've used it in at least one script and perhaps
> others hvae as well.  please consider that, as a general
> rule, tool output is likely to be scraped and changing it
> may break things, so formatting changes should be avoided
> if possible.

It's my wrong.  I reverted these changes.
Thank you for pointing out.
Tetsuya Isaki < />

Home | Main Index | Thread Index | Old Index