pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: shells/oh-my-posh



> Upstream using a sysutil_linux module unconditionally is a bug.  I would
> just file one at the oh-my-posh repo.

It's a goutil bug. The _linux suffix in a file name automatically
makes the file only built on Linux. Since there is nothing really
Linux-specific in the code, the right solution would be to rename the
file to _unix.go and add a //build constraint that includes other
Unix-like OSes.

Looking at the file further, it seems that the whole approach of that
package is misguided. It has "isLinux", "isMac", "isWindows" etc.
calls. Is NetBSD Linux in this logic?

-- 
Benny


Home | Main Index | Thread Index | Old Index