Re: games/xpipeman broken

[Paul Goyette <paul%whooppee.com@localhost>]

On Sun, 8 Jul 2018, Martin Husemann wrote:

> On Sun, Jul 08, 2018 at 08:42:05AM +0800, Paul Goyette wrote:
> > I don't have any idea when the breakage first appeared.  Perhaps it's
> > related to NetBSD ASLR?
>
> #1  0x00007f7ff58fbbb2 in __fail (
>    msg=msg@entry=0x7f7ff5931670 "buffer overflow detected; terminated")
>    at /usr/src/lib/libc/misc/stack_protector.c:103
> #2  0x00007f7ff58fbbdc in __chk_fail ()
>    at /usr/src/lib/libc/misc/stack_protector.c:116
> #3  0x00007f7ff58e007e in __sprintf_chk (buf=<optimized out>,
>    flags=<optimized out>, slen=13, fmt=<optimized out>)
>    at /usr/src/lib/libc/ssp/sprintf_chk.c:58
> #4  0x0000000000403e15 in ?? ()
> #5  0x0000000000402452 in ?? ()
> #6  0x00007f7ff701768e in HandleActions (w=w@entry=0x7f7ff7b3c800,
>    event=0x7f7fffffe3f0, accelWidget=<optimized out>, procs=0x7f7ff7b02958,
>    actions=actions@entry=0x7f7ff7b06e20, stateTree=<optimized out>)
>    at /usr/xsrc/external/mit/libXt/dist/src/TMstate.c:644
>
> The HandleActions calls Notify which invokes xpipeman's "new_game".
> Haven't looked at the details there, but sounds like a genuing app bug.

Perhaps.  But the app doesn't seem to have changed much in almost 20 
years (the distribution file is from August 1998)!  And there don't seem 
to be any new patches since 2012.

There have been some changes to the Makefile.  The last known working 
version would have been about 15 months ago (April 2017) when I added 
the NOT_PAX_MPROTECT_SAFE stuff.  It seems that some whitespace changes 
in the same area were subsequently made about 5 months ago.

All in all, not much has happened, yet the program stopped working...

:)


+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+