Re: ThinkPad - suspend-to-RAM intel-x86 issues and tests

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2018/12/06 0:22, David Brownlee wrote:
> On Sat, 1 Dec 2018 at 01:27, SAITOH Masanobu <msaitoh%execsw.org@localhost> wrote:
> > Committed.
>
> Hi - is this worth pulling up into netbsd-8?

Of course yes!

 
> I ran a quick test and my T420s suspends/resumes fine with a netbsd-8
> kernel and no X11 running. x11 looks to have issues which seem
> resolved in current, but it feels like a worthwhile fix to have in -8.
>
> It needed two other small changes pulled up (git hashes from
> https://github.com/NetBSD/src)
> # 5fca1fb34425590e514f0d745f936998fded9c18 PCIE_HAS_LINKREGS
> # 3fe2d92356e154aef689fc05111ac422c89c0785 PCIE_HAS_ROOTREGS

The above two changes were pulled up two days ago.

> # 2e6fa7a8bbdd4df652e4cfb605385ff915176cbe suspend/resume

I'll send the pullup request today.

> Sample kernel at
> http://ftp.netbsd.org/pub/NetBSD/misc/abs/netbsd-8-amd64-pci-resume/netbsd.gz
> if anyone wants to give it a quick go.
>
> (Many thanks again to msaitoh@ for all the work in analysing and

You're welcome and thank you. If your didn't find the MSI's change,
we couldn't fix this problem.

> fixing this - its really nice to have some fully functional
> suspend/resume use cases (eg :T420s with external mouse :)
>
> David


--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)