Re: Makefile PATH modification with -current 'make'?

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

The most convenient additional system to test was -current/sparc.  On:

$ uname -a
NetBSD lance.technoskunk.fur 7.99.59 NetBSD 7.99.59 (JEAN) #13: Mon Feb 13 17:15:42 CST 2017  sysop%x3650.technoskunk.fur@localhost:/r1/build/current/obj/sparc/sys/arch/sparc/compile/JEAN sparc

running 'make clean' works, but running 'make clean-depends' fails in the
same fashion as originally noted:

$ make clean-depends
sh: not found
make[1]: "sh /x/pkgsrc/pkgtools/cwrappers/../../mk/scripts/shlib-type                    ELF/a.out /usr/sbin/pkg_info" returned non-zero status
make[1]: exec(true) failed (No such file or directory)
*** Error code 1

Stop.
make[1]: stopped in /x/pkgsrc/pkgtools/cwrappers
*** Error code 1

Stop.
make: stopped in /x/pkgsrc/wip/moto4lin


So, that provides a simple test without actually having to try building
anything.


Transplanting "/usr/bin/make" from netbsd-7/sparc, 'make clean-depends'
succeeds:

$ make clean-depends                   
===> Cleaning for cwrappers-20161125
===> Cleaning for digest-20160304
===> Cleaning for gmake-4.1nb3
===> Cleaning for libtool-base-2.4.2nb13
===> Cleaning for libusb-0.1.12nb4
===> Cleaning for osabi-NetBSD-7.99.59
===> Cleaning for x11-links-1.02
===> Cleaning for p2kmoto-0.1rc1
===> Cleaning for jpeg-9b
===> Cleaning for jbigkit-2.1
===> Cleaning for tiff-4.0.7nb1
===> Cleaning for lcms2-2.8
===> Cleaning for mng-2.0.3
===> Cleaning for png-1.6.27
===> Cleaning for qt3-libs-3.3.8nb30
===> Cleaning for qt3-tools-3.3.8nb18

As Joerg noted, "wip/moto4lin/Makefile" is doing something screwy.  It
should probably be changed to be like that of other packages that depend
on qt3-{libs,tools}.

While commenting out the explicit PATH modification allows 'make
clean-depends' to succeed, building fails as it cannot find 'qmake'.
For that, Joerg's suggestion of PREPEND_PATH is probably appropriate.
I don't see any documentation for that variable.  Scanning "/usr/pkgsrc/mk"
turns up examples.

The following patch allows it to build on -current and NetBSD-7:

+diff --git a/moto4lin/Makefile b/moto4lin/Makefile
+index f5782bf896..20e75f121d 100644
+--- a/moto4lin/Makefile
++++ b/moto4lin/Makefile
+@@ -14,6 +14,8 @@ COMMENT=		Filemanager and seem editor for Motorola P2k phones
+ USE_LANGUAGES=		c++
+ USE_TOOLS+=		gmake
+ 
++PREPEND_PATH+=		${QTDIR}/bin
++
+ INSTALLATION_DIRS=	bin
+ 
+ pre-build:
+@@ -27,4 +29,3 @@ do-install:
+ .include "../../x11/qt3-libs/buildlink3.mk"
+ .include "../../x11/qt3-tools/buildlink3.mk"
+ .include "../../mk/bsd.pkg.mk"
+-PATH:=			${QTDIR}/bin:${PATH}

(I do not have commit privileges for pkgsrc-wip.)

-- 
|/"\ John D. Baker, KN5UKS               NetBSD     Darwin/MacOS X
|\ / jdbaker[snail]mylinuxisp[flyspeck]com    OpenBSD            FreeBSD
| X  No HTML/proprietary data in email.   BSD just sits there and works!
|/ \ GPGkeyID:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645