Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: ARM ABI changes/combinations (was Re: Preparation for creating netbsd-7 branch)

On Thu, 24 Jul 2014, Jeff Rizzo wrote:
(Please keep me on the cc: when replying, otherwise we get 24-hour lags such as this waiting for me to check list mail again)


... I'd keep the new ALIAS=evbearm* and remove the old ALIAS=evbarm*
lines, not provide both.

This ^^^ is actually why I have two aliase, because I personally would keep the evbarm* style ones (since that's the port name) while removing the evbearm* style ones, now that earm is the default.

I don't care which of the two you keep, but I think it's ugly to have two aliases that mean the same thing.

If backward compatibility in alias names is important, then let's at least invent a DEPRECATED keyword to mark the old aliases, or use OALIAS= instead of ALIAS=. Adding a new keyword will not require code changes, whereas adding OALIAS= will require a small patch, such as the attached.

--apb (Alan Barrett)
---    6 Jul 2014 18:04:44 -0000       1.285
+++    25 Jul 2014 07:25:58 -0000
@@ -578,7 +578,8 @@ initdefaults()
 # Each line contains a MACHINE and MACHINE_ARCH value, an optional ALIAS
 # which may be used to refer to the MACHINE/MACHINE_ARCH pair, and an
-# optional DEFAULT or NO_DEFAULT keyword.
+# optional DEFAULT or NO_DEFAULT keyword.  OALIAS works just like ALIAS,
+# but is for obsolete or deprecated aliases that may be removed in future.
 # When a MACHINE corresponds to multiple possible values of
 # MACHINE_ARCH, then this table should list all allowed combinations.
@@ -727,6 +728,12 @@ getarch()
+               *" OALIAS=${MACHINE} "*)
+                       # Found a line with a matching OALIAS=<alias>.
+                       warning "Machine alias '${MACHINE}' is deprecated."
+                       found="$line"
+                       break
+                       ;;
                "MACHINE=${MACHINE} "*" NO_DEFAULT"*)
                        # Found an explicit "NO_DEFAULT" for this MACHINE.

Home | Main Index | Thread Index | Old Index