Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Updated IPFilter to version 5.1.2 in -current



On Wed, Jul 25, 2012 at 07:04:39AM -0700, Paul Goyette wrote:
> 
> The attached diffs have been fed back upstream (to Darren), and they do 
> fix the build.  I have not actually used the resulting kernel, so I do 
> not know if it actually is functional.  :)
> 

Just a random nit, not directed at Paul specifically but the NetBSD
style says we shouldn't be initialising variables in the declaration
block.  I know that this is not strictly followed and is rather common
in the source but it would be nice if fixes going in followed the style
(IMHO)

-- 
Brett Lymn
"Warning:
The information contained in this email and any attached files is
confidential to BAE Systems Australia. If you are not the intended
recipient, any use, disclosure or copying of this email or any
attachments is expressly prohibited.  If you have received this email
in error, please notify us immediately. VIRUS: Every care has been
taken to ensure this email and its attachments are virus free,
however, any loss or damage incurred in using this email is not the
sender's responsibility.  It is your responsibility to ensure virus
checks are completed before installing any data sent in this email to
your computer."




Home | Main Index | Thread Index | Old Index