Re: Strange USB crash

[Paul Goyette <paul%whooppee.com@localhost>]

On Fri, 4 Jun 2010, Paul Goyette wrote:

> On Sat, 5 Jun 2010, Jonathan A. Kollasch wrote:
>
> > > My questions to the usb experts:
> > >
> > > 1) should I just rebuild without DIAGNOSTIC and ignore the error?
> > >
> > > 2) Is "something bad(tm)" going to happen later if it does double-free?
> > >
> > > 3) Is this indicative of some other underlying problem?
> > >
> > >    And if so, how would I go about finding and fixing it?
> > >
> > > For now, I'm going to remove DIAGNOSTIC, since I really need my nfs
> > > server to be relatively stable.  :)
> >
> > Sure this isn't kern/30398?
>
> Pretty sure.  The issue in 30398 was a result of test that happens very early 
> in the ohci_softintr() code, around line 1294 (where it is "reversing the 
> done list"):
>
>                        DPRINTFN(5,("add ITD %p\n", sitd));
>                        continue;
>                }
>    >>>>        panic("ohci_softintr: addr 0x%08lx not found", (u_long)done);
>        }
>
>        DPRINTFN(10,("ohci_softintr: sdone=%p sidone=%p\n", sdone, sidone));
>
>
> My panic is happening quite a bit later in the processing, after we've 
> completed the transfer and are deaaling with "process_done" stuff.

Well, it appears that I spoke too soon!  :)

I rebuilt a new kernel without DIAGNOSTIC and lo and behold, it now 
panics at "addr <blah> not found".

Does anyone have any opinion on the proposed solution ("just print and 
ignore the not-found condition rather than panic") from kern/30398?


> -------------------------------------------------------------------------
> | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
> | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
> | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
> | Kernel Developer |                          | pgoyette at netbsd.org  |
> -------------------------------------------------------------------------

-------------------------------------------------------------------------
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:       |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com    |
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |                          | pgoyette at netbsd.org  |
-------------------------------------------------------------------------