Re: Building pkgsrc/x11/gnome-panel fails (pkgsrc-2009Q4)

[Rhialto <rhialto%falu.nl@localhost>]

On Fri 29 Jan 2010 at 13:46:10 +0000, Sad Clouds wrote:
> Maybe compiler needs '-I/usr/pkg/include/gnome-desktop-2.0' flag, in
> order to find include files under that directory?

That was exactly it. It was some puzzling where to insert that though,
and why it was missing in the first place.

As to the former, I hacked around this with the following patch which I
put in my localpatches directory. It is not the correct way to solve it,
but it works with my setup.

--- applets/clock/Makefile.in.dist      2010-01-29 20:38:23.000000000 +0100
+++ applets/clock/Makefile.in   2010-01-29 23:50:04.000000000 +0100
@@ -268,7 +268,7 @@
 CC = @CC@
 CCDEPMODE = @CCDEPMODE@
 CFLAGS = @CFLAGS@
-CLOCK_CFLAGS = @CLOCK_CFLAGS@
+CLOCK_CFLAGS = @CLOCK_CFLAGS@ -I/usr/pkg/include/gnome-desktop-2.0/
 CLOCK_EDS_ICONDIR = @CLOCK_EDS_ICONDIR@
 CLOCK_LIBS = @CLOCK_LIBS@
 CLOCK_MECHANISM_CFLAGS = @CLOCK_MECHANISM_CFLAGS@

The correct place to fix this is of course the configure script, which
determines the value of @CLOCK_CFLAGS@.

I don't know all the macros involved, but I see no other place which may
set CLOCK_CFLAGS, so I'm guessing.  I didn't try it, since pkgsrc
doesn't regenerate configure from configure.in, I think. In any case,
this suggestion ought to be passed upstream, who can correct the idea if
wrong.

--- configure.in.dist   2009-09-21 18:35:48.000000000 +0200
+++ configure.in        2010-01-30 00:01:44.000000000 +0100
@@ -121,7 +121,7 @@
 AM_CONDITIONAL(HAVE_LIBECAL, test -n "$LIBECAL_REQUIREMENT")
 AC_SUBST(CLOCK_EDS_ICONDIR)
 
-PKG_CHECK_MODULES(CLOCK, pango >= $PANGO_REQUIRED gtk+-2.0 >= $GTK_REQUIRED 
glib-2.0 >= $GLIB_REQUIRED gio-2.0 >= $GLIB_REQUIRED $LIBECAL_REQUIREMENT 
librsvg-2.0 dbus-glib-1 gweather >= $GWEATHER_REQUIRED)
+PKG_CHECK_MODULES(CLOCK, pango >= $PANGO_REQUIRED gtk+-2.0 >= $GTK_REQUIRED 
glib-2.0 >= $GLIB_REQUIRED gio-2.0 >= $GLIB_REQUIRED $LIBECAL_REQUIREMENT 
librsvg-2.0 dbus-glib-1 gweather >= $GWEATHER_REQUIRED gnome-desktop-2.0 >= 
$LIBGNOME_DESKTOP_REQUIRED)
 AC_SUBST(CLOCK_CFLAGS)
 AC_SUBST(CLOCK_LIBS)
 
-Olaf.
-- 
___ Olaf 'Rhialto' Seibert    -- You author it, and I'll reader it.
\X/ rhialto/at/xs4all.nl      -- Cetero censeo "authored" delendum esse.