On Sun, May 17, 2009 at 11:40:22PM +0200, Christoph Egger wrote: > Hi, > > a new version of this patch. It mainly avoids a lot of code duplication. > The orders how test it still apply. There's no point of having a specific device for that, even more if saves no text bloat. I understand why it might have been easier to develop and test; I'm just saying it should not end up being committed as this patch. Otherwise it seems to be the way to go. Two comments though: for the SDB700 detection, is it an exact discrete list of revisions, or is the intent more like "revision >= 3a"? And if you have a reference to a specific erratum it'd be better to add it as a comment somewhere. -- Quentin Garnier - cube%cubidou.net@localhost - cube%NetBSD.org@localhost "See the look on my face from staying too long in one place [...] every time the morning breaks I know I'm closer to falling" KT Tunstall, Saving My Face, Drastic Fantastic, 2007.
Description: PGP signature