Re: Atheros Hal and AR5416 (Thinkpad T60p 2007)

[Aran Clauson <aran%100acres.us@localhost>]

I love it when I can answer my own question.  In the 
function v14EepromGet (ah_eeprom_v14.c) the AR_EEP_MACADDR 
case is missing a return HAL_OK statement.   Without the 
return, the thread falls into AR_EEP_REGDMN and returns the 
reg domain (98 apparently).

The attached patch fixes the problem on my laptop.

Aran

On Tuesday 30 December 2008 17:08:47 you wrote:
> Just built 5.99.5 with new ath driver.  I'm getting an
> error in ar5416Attach at
>
> ecode = ath_hal_eepromGet(ah, AR_EEP_MACADDR<
> ahp->ah_macaddr);
>
> ecode is set to 98.
>
> This is running on a Thinkpad T60p 2007 with Atheros PCI
> express card (0x168C, 0x0024).
>
> Aran

Index: sys/external/isc/atheros_hal/dist/ah_eeprom_v14.c
===================================================================
RCS file: /cvsroot/src/sys/external/isc/atheros_hal/dist/ah_eeprom_v14.c,v
retrieving revision 1.2
diff -b -B -r1.2 ah_eeprom_v14.c
56a57,58
>               } else {
>                    return HAL_OK;