Re: iwn not working since 4.99.73

[Robert Elz <kre%munnari.OZ.AU@localhost>]

    Date:        Thu, 6 Nov 2008 09:16:09 +1030
    From:        Brett Lymn <blymn%baesystems.com.au@localhost>
    Message-ID:  <20081105224609.GB17473%baea.com.au@localhost>

  | OK - I will shift it.

Your version 1.24 worked fine.

Could you please close PR 39864 - you have fixed it, perhaps without
even noticing that it existed...  (and the quicker it goes away the
better).

A pullup of these fixes to the netbsd-5 branch is obviously needed.

And last, I made the following (local) change to perhaps allow the scan abort
to still be used in the AUTH case where it is apparently needed, and it
seems to work just fine for a "plain" network (no WPA no WEP) - whether
it really does what it looks like it should do, I don't know.   But if the
IWN_CMD_SCAN_ABORT was ever needed, I think this must be better than
just commenting it out.

kre

--- if_iwn-24.c 2008-11-07 01:43:29.000000000 +0700
+++ if_iwn.c    2008-11-07 01:47:33.000000000 +0700
@@ -1035,7 +1035,8 @@
                /* FALLTHROUGH */
        case IEEE80211_S_AUTH:
                /* cancel any active scan - it apparently breaks auth */
-               /*(void)iwn_cmd(sc, IWN_CMD_SCAN_ABORT, NULL, 0, 1);*/
+               if (sc->is_scanning)
+                       (void)iwn_cmd(sc, IWN_CMD_SCAN_ABORT, NULL, 0, 1);
 
                if ((error = iwn_auth(sc)) != 0) {
                        aprint_error_dev(sc->sc_dev,