Current-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: NetBSD on the Lenovo IdeaPad S10 ?



   Date: Wed, 15 Oct 2008 18:14:16 -0500 (CDT)
   From: "Jeremy C. Reed" <reed%reedmedia.net@localhost>

   I made a few changes to your patch:

   ../../../../dev/ic/bwi.c: In function 'bwi_mac_fw_image_alloc':
   ../../../../dev/ic/bwi.c:1942: warning: format '%u' expects type 'unsigned 
int', but argument 5 has type 'long unsigned int'
   ../../../../dev/ic/bwi.c: In function 'bwi_mac_fw_load':
   ../../../../dev/ic/bwi.c:2004: warning: format '%zx' expects type 'size_t', 
but argument 4 has type 'int'
   ../../../../dev/ic/bwi.c:2021: warning: format '%zx' expects type 'size_t', 
but argument 4 has type 'int'

   So I changed that %u to %lu. And changed the fw_len to (size_t)fw_len.
   I am on amd64 so maybe there is a more portable way for that.

Probably it would be best just to use size_t for all those quantities.
I don't know why I didn't do that to begin with; the types in the
current code may have been copied from the OpenBSD and DragonFlyBSD
drivers.

One issue that I have observed, which I suspect, although I have not
concluded, to be the fault of the driver, is about 10% packet loss
after a while through my bwi(4) interface.  I'd like to know whether
you observe this as well, since I have no way to test the variables
involved (all I have is the one PowerBook G4 with an AirPort Extreme
card), and it could just as well be that the aluminium case is enough
of a Faraday cage to block some of the signal, or there could be some
other issue altogether.  Also, please let me know if anything else
with bwi(4) comes up.


Home | Main Index | Thread Index | Old Index