Re: LHA broken on modern Linux (was: Re: Changing the default .zoo extractor)

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Sun, 2 Nov 2025 17:34:05 +0100
schrieb Jonathan Schleifer <js%pkgsrc.org@localhost>:

> Am 02.11.2025 um 17:22 schrieb Dr. Thomas Orgis <thomas.orgis%uni-hamburg.de@localhost>:
> 
> > With that, it builds just fine with gcc 15.2.0 and should continue to
> > do so for future versions. Should I commit that?  
> 
> If you had a chance to test this and it works (e.g. `make extract` in cross/ppc-morphos-sdk`), please do!
> 

It works (only extraction, not looked at more). I checked that really
gnu89 is needed (it is, because of // comments). There's a warning that
may bother some:

pm2tree.c: In function 'maketree2':
pm2tree.c:94:19: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
   94 |         [redacted, to not show non-free-licensed code]
      |         ~~~~~~~~~~^~~~~~~~~~~~
pm2tree.c:77:19: note: at offset 8 into destination object 'table2' of size 8
   77 |     [redacted]
      |                   ^~~~~~

Looking at the code, I cannot quite see how the compiler decides this,
though. There's a loop with i < given_limit which is at most 8 in
calls, and in the loop body an assignment to table2[i]. Maybe I'm too
tired to see the overflow here.

Anyhow, I committed the FORCE_C_STD.


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg