LHA broken on modern Linux (was: Re: Changing the default .zoo extractor)

[Jonathan Schleifer <js%pkgsrc.org@localhost>]

Today I got contacted by a user that they cannot build cross/ppc-morphos-sdk because it is distributed as an LHA file upstream and archivers/lha fails to build on modern Linux with modern GCC. Apparently the entire code base is still K&R, which is no longer supported by modern GCC.

I don't want to touch this weirdly licensed code in order to not taint myself and my own LHA implementation. Could somebody please refactor and fix archivers/lha? Or can we reconsider switching to devel/objfw for extracting LHA files? I've made the Clang-dependency optional since, so it should be possible to build it relatively quickly on almost all systems. I doubt this requires building a new GCC, as we either have a somewhat sane and modern system which usually comes with ObjC enabled, or it is some weird old UNIX like QNX or UnixWare which has a hopelessly outdated compiler anyway and hence GCC is being built (with ObjC support by default) almost immediately anyway.

And no, archivers/lhasa is not an alternative, it chokes on many archives that lha and ofarc (from devel/objfw) can handle just fine.

-- 
Jonathan