Re: LHA broken on modern Linux (was: Re: Changing the default .zoo extractor)

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Sun, 2 Nov 2025 15:14:43 +0100
schrieb Jonathan Schleifer <js%pkgsrc.org@localhost>:

> Today I got contacted by a user that they cannot build cross/ppc-morphos-sdk because it is distributed as an LHA file upstream and archivers/lha fails to build on modern Linux with modern GCC. Apparently the entire code base is still K&R, which is no longer supported by modern GCC.

What's wrong with this?

 Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/archivers/lha/Makefile,v
retrieving revision 1.45
diff -u -r1.45 Makefile
--- Makefile    27 Jan 2025 19:12:38 -0000      1.45
+++ Makefile    2 Nov 2025 16:20:49 -0000
@@ -22,6 +22,7 @@
 
 USE_TOOLS+=    autoconf automake autoreconf gmake
 GNU_CONFIGURE= yes
+FORCE_C_STD=   gnu89
 
 pre-configure:
        cd ${WRKSRC} && autoreconf --install --symlink
cvs diff: Diffing patches



With that, it builds just fine with gcc 15.2.0 and should continue to
do so for future versions. Should I commit that?


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg