Re: Defaults for PKG_DEVELOPER=yes

OK, so it looks like PKG_DEVELOPER affects the following checks:

- CHECK_INTERPRETER

- CHECK_FAKEHOME

- CHECK_HEADERS

- CHECK_PERMS

- CHECK_PIE

- CHECK_PORTABILITY

- CHECK_RELRO

- CHECK_SHLIBS

- CHECK_SSP

- CHECK_STRIPPED

- CHECK_WRKREF

Also sets:

- MASTER_SORT_RANDOM=NO

Plus adds some extra verbosity:

- mk/pkgformat/pkg/metadata.mk

- mk/tools/pkg-config.mk

- mk/license.mk

- USE_CMAKE (warning if PKG_DEVELOPER set)

- FONTS_VERBOSE

- A scattering of package Makefiles

So I think PKG_DEVELOPER for the non CHECK_* values still makes sense.

I'd like to introduce a new variable - PKGSRC_SKIP_CHECKS? and replace PKG_DEVELOPER usage in the CHECK_* case with it (inverted)

Any objections to the plan (or naming)?

This might be ready for the Q4 branch, but will not commit to the tree before that branch without confirmation :)

David

On Tue, 10 Dec 2024 at 19:27, Roland Illig <roland.illig%gmx.de@localhost> wrote:

Am 10.12.2024 um 10:09 schrieb David Brownlee:
> What would people think of defaulting PKG_DEVELOPER=yes, *but*
> ensuring each additionally enabled check's failure message included
> words to the effect:
>
> "Rerun the failing command with PKG_DEVELOPER=no to skip this check"
>
> Potentially renaming/inverting the variable might also make sense

I fully agree, as PKG_DEVELOPER=no skips very basic sanity checks.

Roland