Re: Adding ninja to tools framework

[Michael Forney <mforney%mforney.org@localhost>]

On 2020-10-19, Denys Nykula <nykula%ukr.net@localhost> wrote:
> Please see if any parts of PATCH v2 in my PR 55027 thread are useful to
> supplement your suggestion.
>
> Meson puts ninja-build in BUILD_DEPENDS. I changed that to USE_TOOLS, and
> had
> used samurai system-wide, until the ninja-build upstream merged my musl
> patch
> and pkgsrc updated to that version.
>
> http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=55027

Thanks, Denys.

Yeah, I've seen your updated patch in PR 55027. I think it is best to
make these changes incrementally, so I'm starting with simply adding
the tool. Once that is in, the next step is to update any packages
that have BUILD_DEPENDS on ninja-build (which probably should have
been TOOL_DEPENDS anyway) to use the tool, just as you've done in your
patch.

As far as controlling TOOL_DEPENDS.ninja based on NINJA_BUILD, I'm not
sure about this. There don't seem to be any other tools that work this
way. But at least with a ninja tool, the implementation that is used
can be controlled in a single place.