Re: New packages for review

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Sun, 2020-02-09 at 07:15 +0000, voidpin wrote:
> Had some time and reviewed the rest of LXQt components.
> Note that, unlike the packages in the original post, I'm not using these components.
> They pull in dependencies that I do not want to use.
> Please review and let me know of issues.
> 
> wip/lxqt
> wip/libsysstat
> wip/lxqt-themes
> wip/obconf-qt
> wip/pavucontrol-qt
> wip/lxqt-about
> wip/lxqt-admin
> wip/lxqt-config
> wip/lxqt-globalkeys
> wip/lxqt-notificationd
> wip/lxqt-openssh-askpass
> wip/lxqt-policykit
> wip/lxqt-powermanagement
> wip/lxqt-qtplugin
> wip/lxqt-session
> wip/lxqt-sudo
> wip/lxqt-panel
> wip/lxqt-runner

Hi,

Here are the results and fixes from another pass at building the lxqt
meta package. (I'm drafting this message in featherpad, BTW.)

308:[154/181] Failed to build    muparser-2.2.6.1

Fails to build when PKG_DEVELOPER=yes. This is a trivial issue.

ERROR: [check-portability.awk] => Found test ... == ...:
ERROR: [check-portability.awk] configure:         if test "x$GCC" == "xyes"; then

Explanation:
===========================================================================
The "test" command, as well as the "[" command, are not required to know
the "==" operator. Only a few implementations like bash and some
versions of ksh support it.

When you run "test foo == foo" on a platform that does not support the
"==" operator, the result will be "false" instead of "true". This can
lead to unexpected behavior.

There are two ways to fix this error message. If the file that contains
the "test ==" is needed for building the package, you should create a
patch for it, replacing the "==" operator with "=". If the file is not
needed, add its name to the CHECK_PORTABILITY_SKIP variable in the
package Makefile.
===========================================================================

*** Error code 1

Needs:

diff --git a/muparser/distinfo b/muparser/distinfo
index 0d92fde1ff..08a8e2f0af 100644
--- a/muparser/distinfo
+++ b/muparser/distinfo
@@ -4,3 +4,4 @@ SHA1 (muparser-2.2.6.1.tar.gz) = e489115c7424b3877bee7646cb748c6ef32cfa7f
 RMD160 (muparser-2.2.6.1.tar.gz) = b488379c2628bd7ba4fdcd4d07f1e6e82152a6cc
 SHA512 (muparser-2.2.6.1.tar.gz) = 01bfc8cc48158c8413ae5e1da2ddbac1c9f0b9075470b1ab75853587d641dd195ebea268e1060a340098fd8015bc5f77d8e9cde5f81cffeade2f157c5f295496
 Size (muparser-2.2.6.1.tar.gz) = 755653 bytes
+SHA1 (patch-configure) = 90c06575962194cfcbc100cc36c41e299918aa2a

cat patch-configure                                                                                      
$NetBSD$

Correct non-portable use of "==" in test(1).

--- configure.orig      2018-10-04 14:31:50.000000000 +0000
+++ configure
@@ -6006,7 +6006,7 @@ $as_echo "$bakefile_cv_gcc31" >&6; }
             SHARED_LD_CXX="\${CXX} -dynamiclib -single_module -headerpad_max_install_names -o"
         fi
 
-        if test "x$GCC" == "xyes"; then
+        if test "x$GCC" = "xyes"; then
             PIC_FLAG="-dynamic -fPIC"
         fi
         if test "x$XLCC" = "xyes"; then

336:[170/181] Failed to build    lximage-qt-0.14.1

Fails the same way discussed previously with qterminal, et al. Needs:

diff --git a/lximage-qt/Makefile b/lximage-qt/Makefile
index f459993399..8e5a42c0d6 100644
--- a/lximage-qt/Makefile
+++ b/lximage-qt/Makefile
@@ -21,6 +21,7 @@ pre-configure:
        ${MKDIR} -p ${WRKSRC}/build
 
 TOOL_DEPENDS+= lxqt-build-tools-[0-9]*:../../wip/lxqt-build-tools
+TOOL_DEPENDS+= qt5-qttools-[0-9]*:../../x11/qt5-qttools
 
 .include "../../x11/qt5-qtx11extras/buildlink3.mk"
 .include "../../wip/libfm-qt/buildlink3.mk"

340:[172/181] Failed to build    pcmanfm-qt-0.14.1

Fails the same way discussed previously with qterminal, et al. Needs:

diff --git a/pcmanfm-qt/Makefile b/pcmanfm-qt/Makefile
index 466227ab87..5d5c5fbd97 100644
--- a/pcmanfm-qt/Makefile
+++ b/pcmanfm-qt/Makefile
@@ -21,6 +21,7 @@ pre-configure:
        ${MKDIR} -p ${WRKSRC}/build
 
 TOOL_DEPENDS+= lxqt-build-tools-[0-9]*:../../wip/lxqt-build-tools
+TOOL_DEPENDS+= qt5-qttools-[0-9]*:../../x11/qt5-qttools
 DEPENDS+=      lxmenu-data-[0-9]*:../../sysutils/lxmenu-data
 
 .include "../../x11/qt5-qtbase/buildlink3.mk"

350:[177/181] Failed to build    lxqt-powermanagement-0.14.1

This won't generate a package as-is for me. (I'm not sure why there'd
be this difference.)

=> Checking file-check results for lxqt-powermanagement-0.14.1
ERROR: ************************************************************
ERROR: The following files are in the PLIST but not in /usr/pkgsrc/wip/lxqt-powermanagement/work/.destdir/usr/pkg:
ERROR:         /usr/pkgsrc/wip/lxqt-powermanagement/work/.destdir/usr/pkg/share/examples/lxqt-powermanagement/xdg/autostart/lxqt-powermanagement.desktop
ERROR: ************************************************************
ERROR: The following files are in /usr/pkgsrc/wip/lxqt-powermanagement/work/.destdir/usr/pkg but not in the PLIST:
ERROR:         /usr/pkgsrc/wip/lxqt-powermanagement/work/.destdir/usr/pkg/share/examples/lxqt/xdg/autostart/lxqt-powermanagement.desktop
*** Error code 1

diff --git a/lxqt-powermanagement/PLIST b/lxqt-powermanagement/PLIST
index ad98b72c2c..6d3f6294c1 100644
--- a/lxqt-powermanagement/PLIST
+++ b/lxqt-powermanagement/PLIST
@@ -2,7 +2,7 @@
 bin/lxqt-config-powermanagement
 bin/lxqt-powermanagement
 share/applications/lxqt-config-powermanagement.desktop
-share/examples/lxqt-powermanagement/xdg/autostart/lxqt-powermanagement.desktop
+share/examples/lxqt/xdg/autostart/lxqt-powermanagement.desktop
 share/icons/hicolor/scalable/devices/laptop-lid.svg
 share/lxqt/translations/lxqt-config-powermanagement/lxqt-config-powermanagement_ar.qm
 share/lxqt/translations/lxqt-config-powermanagement/lxqt-config-powermanagement_ca.qm

356:[180/181] Failed to build    obconf-qt-0.14.1

Fails the same way discussed previously with qterminal, et al. Needs:

diff --git a/obconf-qt/Makefile b/obconf-qt/Makefile
index 7b14dcf750..ac13f39ac6 100644
--- a/obconf-qt/Makefile
+++ b/obconf-qt/Makefile
@@ -23,6 +23,7 @@ pre-configure:
        ${MKDIR} -p ${WRKSRC}/build
 
 TOOL_DEPENDS+= lxqt-build-tools-[0-9]*:../../wip/lxqt-build-tools
+TOOL_DEPENDS+= qt5-qttools-[0-9]*:../../x11/qt5-qttools
 
 .include "../../x11/qt5-qtx11extras/buildlink3.mk"
 .include "../../x11/qt5-qtbase/buildlink3.mk"

358:[181/181] Failed to build    lxqt-config-0.14.1

Fails to package when PKG_DEVELOPER=yes. This is warning that there's
a non-standard library path involved in linking, which needs to be
accounted for.

=> Checking for missing run-time search paths in lxqt-config-0.14.1
ERROR: bin/lxqt-config-appearance: missing library: liblxqt-config-cursor.so
*** Error code 1

Needs:

diff --git a/lxqt-config/Makefile b/lxqt-config/Makefile
index 0bebf0c145..ce9f8eed7a 100644
--- a/lxqt-config/Makefile
+++ b/lxqt-config/Makefile
@@ -18,6 +18,8 @@ CONFIGURE_DIRS=       build
 CMAKE_ARG_PATH=        ..
 
 CMAKE_ARGS+=   -DWITH_INPUT=OFF
+LDFLAGS+=      ${COMPILER_RPATH_FLAG}${PREFIX}/lib/lxqt-config \
+               -L${PREFIX}/lib/lxqt-config/
 
 pre-configure:
        ${MKDIR} -p ${WRKSRC}/build

With those in place, the meta package builds, packages, installs, and
runs successfully for me. Now, that said, I think LXQt needs more
polish in its packaging to be on par with the stock installation
experience of MATE, Xfce, LXDE, and others. As-is, it doesn't present
an actual desktop environment an end user would expect by default.

Regards,

Dave