[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: import wip/prosody
nia <nia%NetBSD.org@localhost> writes:
> On Sat, Jan 18, 2020 at 06:14:16PM -0500, Greg Troxel wrote:
>> Roland Illig <roland.illig%gmx.de@localhost> writes:
>> All good points, but:
>> > pkglint detects practically all cases where variables are overwritten or
>> > redundant. Therefore I don't see a reason to require the += operator, or
>> > to document anything about this in the pkgsrc guide.
>> I don't think pkglint should be the definition of correct. If something
>> is supposed to be a certain way, the guide should say it, and pkglint
>> should warn for things that deviate from the published rules. (Or if
>> there is a good warning not supportable from the guide, the published
>> rules improved.)
> In practice, for verifying a minimum level of correctness for wip packages,
> most developers don't have the guide correctly memorized, so "pkglint doesn't
> complain" is a useful standard there.
That's totally fine, and I use it that way too. I meant to object only
to "pkglint detects this, so there's no need to document it".
Main Index |
Thread Index |