Re: PLIST issue with cmake and ncurses

[David Brownlee <abs%absd.org@localhost>]

On 30 July 2018 at 12:55, Ian D. Leroux <idleroux%fastmail.fm@localhost> wrote:
>
> On Sun, 29 Jul 2018 17:01:34 -0400 "Ian D. Leroux"
> <idleroux%fastmail.fm@localhost> wrote:
> > On Sat, 28 Jul 2018 17:23:26 -0400 D'Arcy Cain <darcy%NetBSD.org@localhost>
> > wrote:
> > > Any thoughts on whether ccmake is really needed?  Maybe
> > > we can make a control that bypasses the config and either builds it
> > > or not based on the user's preference without checking for curses at
> > > all.
> >
> > I'm probably the wrong person to ask, since cmake only ever runs as a
> > build dependency on my system.  I've just commented out the ccmake
> > entry in PLIST and built the package that way.  Once pkg_rr finishes
> > I'll know whether anything I care about notices the difference.
>
> From a quick look at the top-level CMakeLists.txt, it looks like it
> should be enough to define BUILD_CursesDialog, since the automatic
> check for curses should only run when that is undefined.  There seems
> to be some related logic at line 690 to set RPATH when building under
> pkgsrc, but it looks like that gets ignored if BUILD_CursesDialog is 0.

Would it make sense to add an options.mk with ccmake feature,
defaulting to off, so people can get whichever behaviour they need?

On that front I'd be inclined to add an explicit --{no-,}ccmake entry
to the bootstrap configure script analogous to --{no-,}qt-gui

David