tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: issue with python3 and pathlib in requires.txt (eyeD3)



Hello David,
Just a correction to a mistake I have made in patch-setup.py (that can
appear if requirements/requirements.yml does not have a `main_py33'
key).

Leonardo Taccari writes:
> [...]
> (WARNING: I've only tested that the two patches discussed do the trick,
> I have not tested other parts because I'm completely unfamiliar with
> eye3D!)
> [...]

...and, of course, patch-setup.py is incorrect! Whoops!

> [...]
> $NetBSD$
>
> Honor main_py33 key in requirements.yml file to append dependencies only for
> Python <= 3.3 (similar to test_py33).
>
> --- setup.py.orig	2017-11-18 02:27:36.000000000 +0000
> +++ setup.py
> @@ -57,6 +57,9 @@ def getPackageInfo():
>      requirements, extras = requirements_yaml()
>      info_dict["install_requires"] = requirements["main"] \
>                                          if "main" in requirements else []
> +    if sys.version_info[:2] < (3, 4):
> +        info_dict["install_requires"] += requirements["main_py33"] \
> +                                            if "main" in requirements else []
                                                  ^^^^^^
						  This should be
						  main_py33, not main!

>      info_dict["tests_require"] = requirements["test"] \
>                                       if "test" in requirements else []
>      info_dict["extras_require"] = extras
> [...]


Home | Main Index | Thread Index | Old Index