Re: Improve STRIP_DEBUG

[Alistair Crooks <agc%pkgsrc.org@localhost>]

LGTM. Some minor nits:

> ...
> [ ! -h "$${f}" ]
>

I think we're going to have to look for some abstraction for test(1)
options - NetBSD (-current) has:

   -h file
          True if file exists and is a symbolic link.
   -L file
          True if file exists and is a symbolic link. This operator is
retained for compatibility with previous
          versions of this program. Do not rely on its existence; use
-h instead.

while FreeBSD (-current) has:

     -h file       True if file exists and is a symbolic link.  This operator
                   is retained for compatibility with previous versions of
                   this program.  Do not rely on its existence; use -L
                   instead.
     -L file       True if file exists and is a symbolic link.

> ...
> + tmp_f="$${f}.XXX"; \
> ...

I'd be happier, in these security-concious days, with using mktemp(1)
across the board, and bootstrapping if necessary, or maybe even
"mktemp -d"

Best,
Alistair

On 2 January 2018 at 01:25, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:
> I've been working on adding CTF support to pkgsrc, and during that
> work I hit a few issues with our current STRIP_DEBUG support.
>
> This diff fixes them, the details are in the commit log:
>
>   https://github.com/joyent/pkgsrc/commit/f869b311e4d49fcc976018ed06b2996a06f95b78
>
> I've used this successfully for our 2017Q4 builds where packages are
> built with debug, then converted to CTF, and finally stripped to
> reduce size while retaining CTF information.
>
> Please review, thanks.
>
> --
> Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com
>