Re: CVS commit: pkgsrc/pkgtools/rdigest

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Wed, Dec 30, 2015 at 04:58:54PM +0100, Thomas Klausner wrote:
 > > Module Name:	pkgsrc
 > > Committed By:	dholland
 > > Date:		Tue Dec 29 05:00:14 UTC 2015
 > > 
 > > Modified Files:
 > > 	pkgsrc/pkgtools/rdigest: Makefile
 > > 
 > > Log Message:
 > > Use canonical relative path.
 > 
 > (this removes ${.CURDIR} before a path)
 > 
 > We often use ${.CURDIR} when setting variables like DISTINFO_FILE or
 > PATCHES_DIR.
 > 
 > Not sure why. Can anyone shed a light on this?

It doesn't work for DISTINFO_FILE; e.g. if in chat/xchat you take it
out then you get this:

   % make patch
   => Bootstrap dependency digest>=20010302: found digest-20121220
   checksum: distinfo file missing: ../../chat/xchat/distinfo
   ERROR: Make sure the Makefile and checksum file (../../chat/xchat/distinfo)
   ERROR: are up to date.  If you want to override this check, type
   ERROR: "/usr/bin/make NO_CHECKSUM=yes [other args]".
   *** Error code 1

But it does work for PATCHES_DIR.

I'd call this a bug.

 > If we don't need
 > ${.CURDIR} it's easier to read/write and we should clean up pkgsrc for
 > it.

Agreed; we write zillions of relative paths without ${.CURDIR} and
it's unnecessarily confusing to have some that are different.

-- 
David A. Holland
dholland%netbsd.org@localhost