Re: lang/php{54,55} and www/apache24 does not work without ZTS support

[matthew sporleder <msporleder%gmail.com@localhost>]

On Tue, Mar 25, 2014 at 12:31 PM, Takahiro Kambe 
<taca%back-street.net@localhost> wrote:
> Hi,
>
> In message <20140317.235103.1516567348535146321.ryo_on%yk.rim.or.jp@localhost>
>         on Mon, 17 Mar 2014 23:51:03 +0900 (JST),
>         Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost> wrote:
>>>> [Mon Mar 17 20:49:54.145101 2014] [:crit] [pid 19026:tid 140187728347136] 
>>>> Apache is running a threaded MPM, but your PHP Module is not compiled to 
>>>> be threadsafe.  You need to recompile PHP.
>>>> AH00013: Pre-configuration failed
>>>
>>> Is this new breakage, or have our php packages/modules always not worked
>>> with apache24?
>>
>> Oops. This breakage is caused from my change in apache24.
> www/ap-php and some php modules are also broken on phgsrc-2013Q4
> branch, it is too bad.
>
> And effect of maintainer-zts should be consitent in all PHP and its
> modules.  So, how about disable maintainer-zts explicitly?
>
> I'm not yet do runtime test, but it should fix unloadble php modules
> in ap-php.
>
> --
> Takahiro Kambe <taca%NetBSD.org@localhost>/<taca%back-street.net@localhost>
>
>
> Index: lang/php54/Makefile.php
> ===================================================================
> RCS file: /cvsroot/pkgsrc/lang/php54/Makefile.php,v
> retrieving revision 1.6
> diff -u -u -r1.6 Makefile.php
> --- lang/php54/Makefile.php     21 Jul 2013 17:29:47 -0000      1.6
> +++ lang/php54/Makefile.php     25 Mar 2014 16:26:46 -0000
> @@ -72,7 +72,9 @@
>  CONFIGURE_ARGS+=       --without-openssl
>  .endif
>
> -.if !empty(PKG_OPTIONS:Mmaintainer-zts)
> +.if empty(PKG_OPTIONS:Mmaintainer-zts)
> +CONFIGURE_ARGS+=       --disable-maintainer-zts
> +.else
>  CONFIGURE_ARGS+=       --enable-maintainer-zts
>  .endif
>

This disabled zts by default, right?