Re: sqlite3 builtin.mk

[Hans Rosenfeld <rosenfeld%grumpf.hope-2000.org@localhost>]

On Thu, Nov 10, 2011 at 02:23:47PM +0000, David Holland wrote:
> On Thu, Nov 10, 2011 at 03:10:56PM +0100, Hans Rosenfeld wrote:
>  > > > On Thu, Nov 10, 2011 at 13:09, Thomas Klausner 
> <wiz%netbsd.org@localhost> wrote:
>  > > >> 2) change the default pkg-config to include /usr/lib/pkgconfig
>  > > >
>  > > > This looks sensible to me. Why not simply do this?
>  > > 
>  > > Because pkgsrc != NetBSD. Other OSes might store pkg-config stuff in
>  > > other places. And I'm not sure about the consequences of such a global
>  > > flag. On Solaris, there are "native" packages using pkg-config which I
>  > > don't want to use in pkgsrc packages. At least not unconditionally.
>  > 
>  > Builtins are never used unconditionally. Builtin versions are always
>  > checked, and a builtin.mk can do additional checks if necessary (for
>  > optional features or similar things). Besides that, builtin detection
>  > can always be overriden by explicitly setting USE_BUILTIN.* or PREFER.*
>  > variables, either manually or by default in some platform specific .mk
>  > file.
> 
> Yes, but once you add the system pkg-config directory to the
> pkg-config path, other stuff that's in there can leak into the build.
> I don't think doing it that way is a good idea for this precise
> reason...

Yes. I solved this in a few local builtin.mk files by explicitly
adding the .pc files to BUILDLINK_FILES.pkg.


Hans


-- 
%SYSTEM-F-ANARCHISM, The operating system has been overthrown